Skip to content

fix(api-client): Add http-status-codes back as dependency of api client [WPB-22420] #20389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
screendriver merged 1 commit into from
Feb 11, 2026
Merged

fix(api-client): Add http-status-codes back as dependency of api client [WPB-22420] #20389

screendriver merged 1 commit into from
Feb 11, 2026
+2 −0

Conversation

@panuschek
Copy link
Collaborator

@panuschek panuschek commented Feb 11, 2026 •
edited by github-actions bot
Loading

TaskWPB-22420 [Web] General maintenance ticket for PR merges

Pull Request

Summary

  • Fixed api client by adding http-status-codes back as dependency of api-client

Security Checklist (required)

  • [ X ] External inputs are validated & sanitized on client and/or server where applicable.
  • [ X ] API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • [ X ] No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • [ X ] Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)

Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@panuschek panuschek requested review from a team and otto-the-bot as code owners February 11, 2026 10:10
@panuschek panuschek changed the title fix(api-client): Add http-status-codes back as dependency of api client fix(api-client): Add http-status-codes back as dependency of api client [WPB-22420] Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.25%. Comparing base (bb7506a) to head (e913638).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #20389   +/-   ##
=======================================
  Coverage   45.25%   45.25%           
=======================================
  Files        1633     1633           
  Lines       40245    40245           
  Branches     8325     8325           
=======================================
+ Hits        18211    18212    +1     
  Misses      20105    20105           
+ Partials     1929     1928    -1
Flag Coverage Δ
app_webapp 43.43% <ø> (+<0.01%) ⬆️
lib_api_client 50.17% <ø> (ø)
lib_core 58.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026 •
edited
Loading

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • ✅ Passed: 9
  • ❌ Failed: 0
  • ⏭ Skipped: 4
  • 🔁 Flaky: 1
  • 📊 Total: 14
  • ⏱ Total Runtime: 101.4s (~ 1 min 41 sec)
specs/CriticalFlow/messagesIn1On1-TC-8750.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Messages in 1:1 (tags: TC-8750, crit-flow-web)

@screendriver screendriver force-pushed the fix/api-client-fix-missing-dependency branch from 86ada78 to e913638 Compare February 11, 2026 12:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 11, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@screendriver screendriver added this pull request to the merge queue Feb 11, 2026
Merged via the queue into dev with commit 76e600a Feb 11, 2026
54 checks passed
@screendriver screendriver deleted the fix/api-client-fix-missing-dependency branch February 11, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@screendriver screendriver screendriver approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees

No one assigned

Labels

lib: api-client 👕 size: XS type: bug / fix 🐞

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panuschek @screendriver @otto-the-bot